Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fieldCollectionPlace to be repeatable #17

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

mikejritter
Copy link
Contributor

What does this do?
Updates the collectionobject form to include fieldCollectionPlaces so that fieldCollectionPlace displays as a repeatable input.

Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-1395

This was missed when making updates to the profiles which used fieldCollectionPlace as it is being updated to be a repeatable input.

How should this be tested? Do these changes have associated tests?

  • Run the devserver
  • Create a collectionobject
  • See that the Field collection place input is repeatable, and can save/load multiple inputs

Dependencies for merging? Releasing to production?
None

Has the application documentation been updated for these changes?
No

Did someone actually run this code to verify it works?
@mikejritter tested locally

Copy link
Collaborator

@ray-lee ray-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ray-lee ray-lee merged commit 03d0677 into collectionspace:master Mar 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants